and first of all thanks for posting your work, it’s been really useful!

about the code HabtmCounterCache behaviour on github (https://gist.github.com/235652/d196add592288c8ce5d4bd9edf9b19c89bc6fee7).

I fixed one infinite loop that was happening in my app.

I post here it for if someone has the same problem….

on line 357:
$model->{$habtmAlias}->save(array(

$habtmAlias => array(
‘id’ => $habtmId,
$settings['counterCache'] => $count,
),
));

was creating an infinite loop in my app. using cake 3.5

if someone has the same problem can fix it changing it for this:

$model->{$habtmAlias}->id = $habtmId;
$model->{$habtmAlias}->saveField($settings['counterCache'], $count, array(
‘validate’ => false,
‘callbacks’ => false
));

I have seen your HabtmCounterCache behaviour on github (https://gist.github.com/235652/d196add592288c8ce5d4bd9edf9b19c89bc6fee7).

I think there are some bugs in that code:

Line 246
$model->data[$habtmAlias][$habtmAlias] may be empty what causes warning on array_merge in the line 258. You should test for empty value in the line 246:

if (!isset($model->data[$habtmAlias][$habtmAlias]) || empty($model->data[$habtmAlias][$habtmAlias])) {

Line 357
By default, save method check for validation rules. But in line 357 we only want to save/update some model fields, so we should disable validation:

$model->{$habtmAlias}->save(array(
$habtmAlias => array(
‘id’ => $habtmId,
$settings['counterCache'] => $count,
),
),
false
);

Hope this helps.

Thanks for sharing your code!

From twitter:

@AD7six: why have a (total)child_count field at all. no-of-children = (rght – lft -1)/2 .
@neilcrookes: ah, I remember now, it’s for when I add scope functionality
@neilcrookes: when I say remember, I mean, that’s the excuse I just came up with for being too dumb to realise no-of-children = (rght – lft -1)/2

$numberOfTotalChildren = ($result[$model][$right] – $result[$model][$left] – 1) / 2;