Comments on: CakePHP Sequence Behavior

By: Neil Crookes

Neil Crookes — Tue, 09 Mar 2010 23:55:11 +0000

@craig, thanks for that, what might work is merging the values for old groups and new groups before passing it to _getHighestOrder().

E.g. in beforeSave() > Editing > Changing group > Order not specified section, change it to:

// Insert at end of new group
$model->data[$model->alias][$orderField] = $this->_getHighestOrder(
$model,
array_merge(
$this->_oldGroups[$model->alias]
$this->_newGroups[$model->alias]
)
) + 1;

I’ll check it out when I get chance, and add it with suitable test cases.

By: craig

craig — Tue, 09 Mar 2010 21:08:07 +0000

Great behavior — Just what I needed!

fwiw, I’m grouping on three columns, and I find that I need to specify the value for each of the three when I want to change the value of any one of them. That is, if I change the value of one grouping field, I need to also provide the existing values for the other two fields when I update the record.

Otherwise _getHighestOrder() will not find any matching records, and will use the default start_at order number.

This is probably the expected behavior, but I thought I’d mention it.

By: Neil Crookes

Neil Crookes — Mon, 22 Feb 2010 23:32:27 +0000

@Aurimas, thanks, I’ll check it out.

By: Aurimas

Aurimas — Mon, 22 Feb 2010 09:47:33 +0000

Hello,

Thanks for fixing some problems, but found some new ^^. If both belonging models have sequence behaviour i was getting fatal error.

Fatal error: [] operator not supported for strings in C:\..\cake\libs\model\datasources\dbo_source.php on line 1126

For ex. User belongsTo Group and both have behaviour attached.
Have find quick fix 171 line change:
$queryData['order']
to
$queryData['order'][]

i would commit changes but never used git ^^

Regards,
Aurimas

By: Neil Crookes

Neil Crookes — Thu, 11 Feb 2010 22:52:43 +0000

@prgTW, nice one, thanks for your contribution. I’ll add the methods as soon as I get chance.

By: prgTW

prgTW — Thu, 11 Feb 2010 01:21:13 +0000

http://pastebin.com/f7a5bbae9

I’ve added moveUp() and moveDown() functions for moving an element so it could be compatible with the core CakePHP TreeBehavior. Hope You enjoy :).

@Neil
You could merge it into Your behavior on github :)

By: Neil Crookes

Neil Crookes — Wed, 27 Jan 2010 00:43:03 +0000

@Aurimas thanks for the comment, I’ll check it out. Going to try and fine the time to refactor the behavior into a plugin so it can be added to project more easily. I think you’re right, there are some funny things going on when you have it attached to lots of models and you are doing multiple save operations on more than one of them, perhaps triggered by callbacks on other models. I’ll have a look at this at the same time.

By: Aurimas

Aurimas — Tue, 26 Jan 2010 11:21:49 +0000

Nice and usefull behaviour, but i found some problems with it.
at behaviour _setup() on line 171
$model->order = $this->escapedOrderField = $model->escapeField($this->orderField);

escapedOrderField is not correctly set. If use behaviour at many models. I was getting incorectly generated query, it was strange that in query was values from other model which is not belong to current model in any way. So figured out that it was problem in
$this->update = array(
‘action’ => array(
$this->escapedOrderField => $this->escapedOrderField . ‘ + 1′
),
‘conditions’ => array(
array($this->escapedOrderField . ‘ >=’ => $this->newOrder),
array($this->escapedOrderField . ‘ $this->oldOrder),
),
);
as it uses $this->escapeOrderField, and value was always the same model not currently updating.
Fixed it by moving escapeOrderField initialization to setSaveUpdateData method, and it is working fine.

Don’t know if it good way to solve this, as escapedOrderField is used also on other methods. Just take a look ;)

Thanks,
Aurimas

By: Useful CakePHP Tutorial Roundup for June 26, 2009

Useful CakePHP Tutorial Roundup for June 26, 2009 — Sun, 15 Nov 2009 22:24:02 +0000

[...] CakePHP Sequence Behavior – Neil Crookes (February 9, 2009) Like so many other features, I was researching the best way to handle re-ordering of records via a CMS (e.g. so a user can change the order of photos in a gallery) when I chanced upon Neil’s handy little model behavior. His implementation is pretty smart in that it only executes database queries when it absolutely needs to, rather than just updating every record in a group when any order is changed. Throw in some JQuery AJAX drag and drop that Neil also provides – I’ve been a Prototype/Scriptaculous guy for a long time, but this is easy as pie! – and you’ve got a great re-ordering system in no time. [...]

By: Tim Koschützki

Tim Koschützki — Tue, 10 Nov 2009 07:14:29 +0000

Good stuff Neil!

I am going to try this in a project soon.

Thanks or sharing.