Comments on: Send ‘em back from whence they came

By: unclezoot

unclezoot — Sat, 26 Sep 2009 23:12:15 +0000

Hi,

Thanks for making this, has really saved me some hours of my life.
One thing I have noticed is that you’re not currently checking for ‘bad requests’, which means requests to missing images/controllers get put onto the stack.

One might consider doing something like this:

if ($this->Controller->name’CakeError’){ ….

Thanks again

By: Petey

Petey — Sun, 16 Aug 2009 01:11:16 +0000

Not to be a bore, but you don’t say “from whence they came” – it’s just “whence they came.”

“Whence” is not an antiquated form of “where.” It means “from which” or “from what place.” So “from” is already incorporated. Saying “from whence” is equivalent to saying “from from which.”

It’s just “whence.”

By: Dieter@be

Dieter@be — Thu, 09 Apr 2009 08:42:19 +0000

Hey Neil,
great component! Simple and does the job.

Too bad that if you have multiple tabs open (e.g. 2 non-admin tabs) in firefox they share the same session and hence the same stack.
A solution for that could be to use http://www.nektra.com/oss/firefox/extensions/cookiepie/

By: Rick Guyer

Rick Guyer — Wed, 08 Apr 2009 03:28:37 +0000

Thanks Neil for the work you’ve done on this component. When I attempt to use your history component, $this->params[‘url’] in beforeRender() does not get populated. I can however get to the URL using $this->Controller->params[‘url’]. Am I missing something?

By: Neil Crookes

Neil Crookes — Tue, 10 Feb 2009 20:39:14 +0000

@Frankie, cheers for pointing that out, I’ve updated the code on github.

By: Frankie

Frankie — Mon, 09 Feb 2009 08:11:00 +0000

Nice component. I’ve found some problems using it when the app is running on a subdirectory. The $_SERVER['REQUEST_URI'] prepends the subdirectory name so the resultant uri is wrong. For example:

If the subfolder name is example, the $uri variable populates with /example/controller/action, and the url returned by History->back() is something like /example/example/controller/action.

My solution is the following: change lines 133 to 135 with

$uri = ‘/’.$this->Controller->params['url']['url'];